From 4b50d3765d4d94d622ca0e2e544d3c97dc01fac4 Mon Sep 17 00:00:00 2001 From: Severin Beauvais Date: Thu, 6 Jul 2023 08:46:54 -0700 Subject: [PATCH 1/2] - updated browserslist config - app version = 5.0.3 - added corp-type-module dependency - mapped EntityType to CorpTypeCd --- .browserslistrc | 2 +- package-lock.json | 5 +++-- package.json | 3 ++- src/enums/entity-type.ts | 34 ++++++++++++++++++---------------- 4 files changed, 24 insertions(+), 20 deletions(-) diff --git a/.browserslistrc b/.browserslistrc index 8f9604394..214388fe4 100644 --- a/.browserslistrc +++ b/.browserslistrc @@ -1,3 +1,3 @@ > 1% last 2 versions -not ie <= 10 +not dead diff --git a/package-lock.json b/package-lock.json index b72f5137b..846caf740 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,14 +1,15 @@ { "name": "name-request", - "version": "5.0.2", + "version": "5.0.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "name-request", - "version": "5.0.2", + "version": "5.0.3", "dependencies": { "@babel/compat-data": "^7.12.13", + "@bcrs-shared-components/corp-type-module": "1.0.12", "@bcrs-shared-components/enums": "1.0.40", "@bcrs-shared-components/genesys-web-message": "1.0.0", "@bcrs-shared-components/interfaces": "1.0.22", diff --git a/package.json b/package.json index 08e36d50d..3ecaa6eeb 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "name-request", - "version": "5.0.2", + "version": "5.0.3", "private": true, "appName": "Name Request UI", "sbcName": "SBC Common Components", @@ -14,6 +14,7 @@ }, "dependencies": { "@babel/compat-data": "^7.12.13", + "@bcrs-shared-components/corp-type-module": "1.0.12", "@bcrs-shared-components/enums": "1.0.40", "@bcrs-shared-components/genesys-web-message": "1.0.0", "@bcrs-shared-components/interfaces": "1.0.22", diff --git a/src/enums/entity-type.ts b/src/enums/entity-type.ts index 8cb29fb32..50fc1e686 100644 --- a/src/enums/entity-type.ts +++ b/src/enums/entity-type.ts @@ -1,29 +1,31 @@ +import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module' + /** Enum for Entity Type codes. */ export enum EntityType { // BC Entity Types: - BC = 'BC', - CC = 'CC', - CP = 'CP', - CR = 'CR', - DBA = 'DBA', - FI = 'FI', - FR = 'FR', - GP = 'GP', - LL = 'LL', - LP = 'LP', - PA = 'PA', - PAR = 'PAR', + BC = CorpTypeCd.BC_COMPANY, + CC = CorpTypeCd.BC_CCC, + CP = CorpTypeCd.COOP, + CR = CorpTypeCd.BC_CORPORATION, + DBA = CorpTypeCd.DOING_BUSINESS_AS, + FI = CorpTypeCd.FINANCIAL, + FR = CorpTypeCd.NR_SOLE_PROP, + GP = CorpTypeCd.PARTNERSHIP, + LL = CorpTypeCd.LL_PARTNERSHIP, + LP = CorpTypeCd.LIM_PARTNERSHIP, + PA = CorpTypeCd.PRIVATE_ACT, + PAR = CorpTypeCd.PARISHES, SO = 'SO', - SP = 'SP', - UL = 'UL', + SP = CorpTypeCd.SOLE_PROP, + UL = CorpTypeCd.BC_UNLIMITED, // XPRO Entity Types: - XCR = 'XCR', + XCR = CorpTypeCd.XPRO_CORPORATION, XUL = 'XUL', RLC = 'RLC', XLP = 'XLP', XLL = 'XLL', - XCP = 'XCP', + XCP = CorpTypeCd.XPRO_COOP, XSO = 'XSO', INFO = 'INFO', // special value for sub-menu From 0a77aba255a57df98b104221d798c5a215098996 Mon Sep 17 00:00:00 2001 From: Severin Beauvais Date: Thu, 6 Jul 2023 12:23:43 -0700 Subject: [PATCH 2/2] - renamed xxx.services -> xxx-services - changed some strings to EntityType - worked around EntityType type issue - sorted items in entityTypeCdToText() --- src/App.vue | 2 +- .../advanced-search-retrieve.vue | 2 +- src/components/common/applicant-info-1.vue | 2 +- src/components/dialogs/advanced-search.vue | 2 +- src/components/dialogs/cancel.vue | 2 +- src/components/dialogs/payment-complete.vue | 2 +- src/components/dialogs/refund.vue | 2 +- src/components/dialogs/resubmit.vue | 2 +- .../existing-request-display.vue | 2 +- src/components/new-request/stats.vue | 2 +- .../entity-cannot-be-auto-analyzed.vue | 2 +- .../submit-request/reserve-submit.vue | 2 +- src/enums/entity-type.ts | 26 ++++++++++++++----- src/interfaces/mapping.ts | 6 +++-- src/interfaces/models.ts | 2 +- src/interfaces/new-request-interface.ts | 2 +- src/mixins/common-mixin.ts | 23 +++++++++------- src/mixins/displayed-component-mixin.ts | 2 +- src/mixins/nr-affiliation-mixin.ts | 4 +-- src/mixins/payment-mixin.ts | 2 +- src/mixins/update-user-mixin.ts | 2 +- .../{auth.services.ts => auth-services.ts} | 0 ...iness.services.ts => business-services.ts} | 0 .../{namex.services.ts => namex-services.ts} | 0 src/store/actions.ts | 2 +- src/store/getters.ts | 2 +- src/views/landing.vue | 2 +- 27 files changed, 58 insertions(+), 41 deletions(-) rename src/services/{auth.services.ts => auth-services.ts} (100%) rename src/services/{business.services.ts => business-services.ts} (100%) rename src/services/{namex.services.ts => namex-services.ts} (100%) diff --git a/src/App.vue b/src/App.vue index 86f3140da..92e3d020b 100644 --- a/src/App.vue +++ b/src/App.vue @@ -105,7 +105,7 @@ import SbcFooter from 'sbc-common-components/src/components/SbcFooter.vue' // Interfaces / Enums import { ActionBindingIF } from '@/interfaces/store-interfaces' -import NamexServices from './services/namex.services' +import NamexServices from './services/namex-services' import { PAYMENT_REQUIRED } from 'http-status-codes' @Component({ diff --git a/src/components/advanced-search/advanced-search-retrieve.vue b/src/components/advanced-search/advanced-search-retrieve.vue index 3960b698d..588ca0db5 100644 --- a/src/components/advanced-search/advanced-search-retrieve.vue +++ b/src/components/advanced-search/advanced-search-retrieve.vue @@ -51,7 +51,7 @@ import AdvancedSearchDates from '@/components/advanced-search/advanced-search-da import { FormType, NameRequestI } from '@/interfaces' import { Action, Getter } from 'vuex-class' import { ActionBindingIF } from '@/interfaces/store-interfaces' -import NamexServices from '@/services/namex.services' +import NamexServices from '@/services/namex-services' @Component({ components: { diff --git a/src/components/common/applicant-info-1.vue b/src/components/common/applicant-info-1.vue index f34bb3c3a..084a15cc7 100644 --- a/src/components/common/applicant-info-1.vue +++ b/src/components/common/applicant-info-1.vue @@ -405,7 +405,7 @@ import { ActionBindingIF } from '@/interfaces/store-interfaces' import { EmptyApplicant, NameRequestI } from '@/interfaces' import { removeExcessSpaces } from '@/plugins/utilities' import { CanJurisdictions, IntlJurisdictions } from '@/list-data' -import AuthServices from '@/services/auth.services' +import AuthServices from '@/services/auth-services' @Component({ components: { diff --git a/src/components/dialogs/advanced-search.vue b/src/components/dialogs/advanced-search.vue index e0d51084f..12b1edc63 100644 --- a/src/components/dialogs/advanced-search.vue +++ b/src/components/dialogs/advanced-search.vue @@ -135,7 +135,7 @@