Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds new entries to table. #104

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: Adds new entries to table. #104

merged 3 commits into from
Nov 22, 2024

Conversation

gregorylavery
Copy link
Collaborator

@gregorylavery gregorylavery commented Nov 15, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # CE-895

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Deployed locally and noted the new entries show up in the correct ordering in the dropdown.
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you have this in a versioned script and not a repeatable script (which isn't recommended as if there are bugs, a new version will be required or the PVC will need to be scrapped) you need to remember to increment the code table version number in the configuration table (which is also why it's recommended that all code table updates go into the code tables script.)

@afwilcox afwilcox added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 3dad7f0 Nov 22, 2024
9 checks passed
@afwilcox afwilcox deleted the CE-895 branch November 22, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants