Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRC-693: model cleanup #310

Merged
merged 1 commit into from
Jan 19, 2019
Merged

PRC-693: model cleanup #310

merged 1 commit into from
Jan 19, 2019

Conversation

severinbeauvais
Copy link
Contributor

@severinbeauvais severinbeauvais commented Nov 16, 2018 •
edited
Loading

  • deleted obsolete, commented out template code
  • renamed a template variable for easier-to-understand code
  • deleted code that referenced obsolete Tags properties
  • deleted obsolete application Internal object
  • initialized/assigned object dates correctly
  • initialized/assigned sub-objects correctly
  • deleted obsolete Tags properties
  • deleted obsolete comment period Description and Internal object
  • fixed some code indentation
  • deleted obsolete code properties
  • added explicit paging parameters to getApplications()

@NickPhura NickPhura self-requested a review January 9, 2019 00:24
NickPhura
NickPhura approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NickPhura NickPhura merged commit 88072bb into bcgov:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickPhura NickPhura NickPhura approved these changes

@marklise marklise Awaiting requested review from marklise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@severinbeauvais @NickPhura