Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.0.0 release #1422

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Prepare 1.0.0 release #1422

merged 1 commit into from
Oct 29, 2024

Conversation

esune
Copy link
Member

@esune esune commented Oct 29, 2024

Bump versions for 1.0.0 release

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@esune esune requested review from i5okie and loneil October 29, 2024 17:54
@@ -1,6 +1,6 @@
# Traction

![version: 0.3.4](https://img.shields.io/badge/Version-0.3.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.5.1](https://img.shields.io/badge/AppVersion-0.5.1-informational?style=flat-square)
![version: 0.3.4](https://img.shields.io/badge/Version-0.3.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
Copy link
Contributor

@loneil loneil Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be version 0.5.1 1.0.0 for the first badge there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or no, that's chart version right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app version is 1.0.0 - the chart version is 0.3.4 and was bumped after the prior release.

@esune
Copy link
Member Author

esune commented Oct 29, 2024

Something odd is happening with the GHCR authentication,. which is causing the checks to fail.
@i5okie did our token maybe expire or something related to GHCR authentication?

@esune
Copy link
Member Author

esune commented Oct 29, 2024

Something odd is happening with the GHCR authentication,. which is causing the checks to fail. @i5okie did our token maybe expire or something related to GHCR authentication?

Nevermind, as @loneil just pointed out this is because I opened the PR from my fork... 🤦🏻

@esune esune merged commit 32dea49 into bcgov:main Oct 29, 2024
5 of 8 checks passed
@esune esune deleted the release/1.0.0 branch October 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants