Clojure: Levenshtein updates #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEZ
force-pushed
the
levenshstein-corrections
branch
from
94ec047 to
149cda6
Compare
Merged
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some Levenshtein implementations skip redundant comparisons in a way that the reference implementation does not.And also that some implementations calculates the wrongmin_distance.I think we can make the run.sh script check for correctness of the output. I can have a stab at that, if you like, @bddicken. The tricky one is
loopswith it'srandom(), but there's still a range we can check there I think.UPDATE: Since most of my changes where about enforcing the old reference implementation, I have removed those now. And instead updated the Clojure implementation to match the new reference implementation.