Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to first-timer-issues. #510

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

freakboy3742
Copy link
Member

Updates references to first-timer-issues to "good first issue"

Should not be merged before beeware/.github#4 has been deployed across repos.

Refs beeware/.github#4
Refs beeware/briefcase#1003

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Visit the preview URL for this PR (updated for commit c255a8f):

https://beeware-org--pr510-labels-ff8slzhh.web.app

(expires Tue, 17 Jan 2023 05:40:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec

Comment on lines 33 to 34
If you're a first time contributor, some tickets are also tagged as
`[first-timers-only] <https://github.com/search?q=user%3Abeeware+label%3Afirst-timers-only+is%3Aissue+is%3Aopen&type=>`__.
`[good first issue] <https://github.com/search?q=user%3Abeeware+label%3Agood%20first%20issue+is%3Aissue+is%3Aopen&type=>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the label contains spaces, I think it must be wrapped in quotes, like this:

https://github.com/search?q=user%3Apython+label%3A%22awaiting+review%22+is%3Aopen

Also, I don't ever see an empty type argument when doing interactive searches: it's either set explicitly to "issues", or it's not present at all. So for safety, I suggest we set it explicitly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; updated.

@freakboy3742
Copy link
Member Author

I've applied beeware/.github#4 across all non-archived repos, so issue tags should be consistent across all repos.

@freakboy3742 freakboy3742 merged commit 5e35f1a into beeware:lektor Jan 11, 2023
@freakboy3742 freakboy3742 deleted the labels branch January 11, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants