-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead generate and DeprecationWarning: Gtk.Misc.set_alignment is deprecated the generate Android App #1167
Comments
Thanks for the report. The wm_class warning has been reported as part of #1147; the The |
Marking this for first timers because identifying the exact lines causing these deprecations, and hunting down the non-deprecated replacements could make a fun first-timer exercise. |
I will debug the code in more detail, it will be another interesting challenge |
@freakboy3742 |
@Vipul-Cariappa Thanks for getting to the bottom of that... and thanks for drawing our attention to the fact that it's no longer maintained. Since we're dependent on that functionality, we may need to look into adopting/forking gbulb... |
An update: As Gbulb is not being maintained, it looks like James Henstridge (who is well known in the GTK community) has developed an alternative. From the API docs, it looks like it should be a very minor change to adopt asyncio-glib over Gbulb - we only need to modify the event loop initialisation code in Toga-GTK's |
From some investigation, asyncio-glib may not be appropriate here, as it doesn't have full GTKApplication integration. |
BeeWare has now taken over ownership of Gbulb; as of the 0.6.2 release, this |
@freakboy3742 I see that you added the set_app function in src/gtk/toga_gtk/app.py in 67d2a5f in 2017 and the comment shows it being deliberate despite set_wmclass being deprecated. FWIW, my tests were unable to confirm the necessity of this code. I even went so far as to remove the entire set_app function. To no ill effect and the application name stayed "Hello World", too. Can you provide a test case? |
@leggewie I suspect this might be highly distribution dependent. Using Ubuntu 20.04, running Toga Tutorial 0, using |
I was running focal myself until very recently, I'm now on Jammy. I'd say, that makes it fairly close. I'm not sure it's the distro, but maybe the DM (I run unity, but I also tried with budgie) or some local configuration. I've attached a minimal helloworld "project" that works fine for me without set_wmclass. Can you confirm how it behaves for you? Can you even try in a temporary guest account to rule out local configuration interference? |
This is an Ubuntu 20.04 box that I use exclusively for testing Linux configurations. It's entirely default "as installed" configuration other than installing Python et al to get the code running. I see this behavior on any app, including your minimal helloworld, on any user account. |
Closing in favour of #1718. |
DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
def _make_subprocess_transport(self, protocol, args, shell,
DeprecationWarning: Gtk.Window.set_wmclass is deprecated
self.native.set_wmclass(app.interface.name, app.interface.name)
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: Widget.set_hidden()
DeprecationWarning: Gtk.Misc.set_alignment is deprecated
self.native.set_alignment(*gtk_alignment(value))
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_alignment()
[GTK+] Not implemented: TextInput.clear_error()
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_font()
[GTK+] Not implemented: TextInput.set_alignment()
[GTK+] Not implemented: TextInput.clear_error()
[GTK+] Not implemented: Widget.set_hidden()
[GTK+] Not implemented: Button.set_background_color()
The text was updated successfully, but these errors were encountered: