Adopt Rubicon 0.4.5rc1 #1751
Merged
Adopt Rubicon 0.4.5rc1 #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhsmith Putting this up for review so I can merge it tomorrow as soon as CI passes (which it should, once the rc1 release is published). |
mhsmith
reviewed
Jan 24, 2023
cocoa/setup.py
Outdated
| @@ -18,7 +18,7 @@ | |||
| setup( | |||
| version=version, | |||
| install_requires=[ | |||
| "rubicon-objc>=0.4.4", | |||
| "rubicon-objc>=0.4.5rc1", | |||
There was a problem hiding this comment.
As I mentioned in #1750, it might be useful to set an upper limit of 0.5.0.
mhsmith
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cocoa and iOS to set a rubicon 0.4.5rc1 minimum version. This is required because 0.4.4 had to be yanked, as it is incompatible with the version of Toga that is available for general use (0.3.0dev39). By publishing a prerelease version of Rubicon, and then including a version specifier that will pick up that prerelease, we can have access to the new features of Rubicon without affecting current production users.
This will fail CI until rubicon-objc 0.4.5rc1 is publishes (hopefully early tomorrow).
Fixes #1750
PR Checklist: