Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[widget audit] toga.ActivityIndicator #1819

Merged
merged 12 commits into from
Mar 22, 2023

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Mar 21, 2023

A testing and documentation audit of the toga.ActivityIndicator widget.

Includes the content from #1799.

Audit checklist

  • Core tests ported to pytest
  • Core tests at 100% coverage
  • Core docstrings complete, and in Sphinx format
  • Documentation complete and consistently formatted
  • cocoa backend at 100% coverage
  • winforms backend at 100% coverage
  • gtk backend at 100% coverage
  • iOS backend at 100% coverage
  • android backend at 100% coverage
  • Widget support table updated

@freakboy3742 freakboy3742 marked this pull request as ready for review March 21, 2023 03:31
@freakboy3742
Copy link
Member Author

This is 100% coverage on the platforms that have currently implemented ActivityIndicator. It's not a complex widget to implement - winforms is the only complication because it doesn't have a native spinner widget (AFAICT).

The question becomes whether we treat the goal of this audit as "test all the widgets/features currently implemented", or "complete the implementations". My inclination for now is to do the latter, if only because having tasks like this on the backlog makes finding sprint tasks much easier, and we can get a much better impression of where we are at before getting bogged down in actually fixing them.

@freakboy3742 freakboy3742 mentioned this pull request Mar 21, 2023
10 tasks
@mhsmith mhsmith merged commit 28c2c7d into beeware:main Mar 22, 2023
@freakboy3742 freakboy3742 deleted the audit-activityindicator branch March 22, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants