Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[widget Audit] toga.Tree #2017

Merged
merged 38 commits into from
Aug 29, 2023
Merged

[widget Audit] toga.Tree #2017

merged 38 commits into from
Aug 29, 2023

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Jun 28, 2023

Audit of Tree.

Includes an audit of TreeSource as well, as Tree uses TreeSource

Builds on #2011 because of dependencies on Table (especially on GTK)

  • Modifies the API for insert and append on TreeSource to remove the parent argument. This makes the API for insert/append more consistent with list.
  • Adds the ability to have a table with no header row.
  • Adds the ability to add/remove columns from a Tree
  • Renames on_double_click to on_activate to avoid a specific GUI action.
  • Defaults to an empty string for missing data. This message was causing more confusion than benefit.

Fixes:

Related:

Audit checklist

  • Core tests ported to pytest
  • Core tests at 100% coverage
  • Core docstrings complete, and in Sphinx format
  • Documentation complete and consistently formatted
  • cocoa backend at 100% coverage
  • winforms backend at 100% coverage - no implementation
  • gtk backend at 100% coverage
  • iOS backend at 100% coverage - no implementation
  • android backend at 100% coverage - no implementation
  • Widget support table updated
  • Widget Issue backlog reviewed

@freakboy3742 freakboy3742 changed the title Audit tree [widget Audit] toga.Tree Jun 28, 2023
@freakboy3742 freakboy3742 mentioned this pull request Jun 28, 2023
4 tasks
@freakboy3742 freakboy3742 marked this pull request as ready for review June 30, 2023 06:03
@freakboy3742 freakboy3742 merged commit 237ccee into beeware:main Aug 29, 2023
40 checks passed
@freakboy3742 freakboy3742 deleted the audit-tree branch August 29, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of GTK.TreeIter Raises DeprecationWarning SimpleTree widget
3 participants