-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[widget Audit] toga.Window #2058
Conversation
0a1e9e9
to
772ff95
Compare
0c3afa9
to
7cd3fde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a look at this because it forms the base line for #2061 and was curious about such fundamental changes. I've mostly left comments regarding the macOS part, this is not a proper review and more of a curious glance :)
Generally I have the impression that the relationship between widgets and containers is a lot clearer now, in large parts also thanks to #1969!
Audit of Window and MainWindow.
multiselect
has been renamedmultiple_select
, for consistency with Table, Tree, etc.resizeable
andcloseable
have been renamed to match US spelling.test_window
testbed file to differentiate between mobile and desktop; and the requirements of the window probe are significantly different.iconify()
, they're explicitly documented as "this might do nothing, depending on the window manager".Fixes:
Audit checklist