Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed argument name for Command handlers #2222

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

HalfWhitt
Copy link
Contributor

Changed the first non-self parameter name in Command handlers to command.

The ActionHandler protocol is defined as accepting self, command: Command, **kwargs, where command is the command that triggered the action. In the codebase, handlers were defined with this parameter named app and in one case widget. Especially since none of the defined handlers reference the argument, this is an entirely semantic fix with no runtime significance.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks!

@freakboy3742 freakboy3742 merged commit cb2a27a into beeware:main Nov 12, 2023
35 checks passed
@HalfWhitt HalfWhitt deleted the correct-menu-command-arg-name branch November 13, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants