Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Android get_terminal_size monkey patch #2336

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Jan 10, 2024

This monkey patch was to prevent the "avc: denied" log spam from #1962. It's now been incorporated into Chaquopy 15, so it can be removed from the testbed after beeware/briefcase-android-gradle-template#78 is merged.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith
Copy link
Member Author

mhsmith commented Jan 10, 2024

The "avc: denied" messages are still appearing in CI because beeware/briefcase-android-gradle-template#78 hasn't been merged yet. After it's merged, re-run CI and they should disappear.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged the template change and re-ran the Android CI testbed, and it seems to be working well.

@freakboy3742 freakboy3742 merged commit fd71291 into beeware:main Jan 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants