Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed use of no-op argument for Choices #2427

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Removed use of no-op argument for Choices #2427

merged 2 commits into from
Feb 27, 2024

Conversation

HalfWhitt
Copy link
Contributor

Following up on beeware/travertino#139 and removing the unused default argument from Pack.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@freakboy3742 freakboy3742 merged commit 0f3bde2 into beeware:main Feb 27, 2024
34 checks passed
@HalfWhitt HalfWhitt deleted the remove-default-choices branch February 27, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HalfWhitt @freakboy3742