Allow running without entry_points metadata #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
force-pushed
the
optional-entry-points
branch
from
411e33c
to
e725bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_platform_factorycurrently requires the entry_points metadata to be installed, even when it's unnecessary because the backend is set manually using TOGA_BACKEND environment variable. This makes it impossible to run from source code which hasn't been installed with pip, which is something I often do to speed up Android development – avoiding re-running pip for every change by listing toga-android in pyproject.toml undersourcerather thanrequires.This is a minor rearrangement to make sure we check the entry_points only when necessary.