Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified invokation order of TextInput on_change and validation withi… #2594

Conversation

PistachioCannoli
Copy link
Contributor

…n a new private method in toga core, then updated the backends to call the new core method

I updated the invocation order of _validate() and on_change() in toga core and the appropriate backends where on_change() is validated for TextInputs. I did this by creating a new private method within the TextInput class named _value_changed and switched the call order between _validate and on_change. Then I attempted to add to existing test code to validate the _value_changed method. But I was not able to update any documentation reflecting the change.

fixes issue where validation was called before a text change was recognized, thus preventing certain fields from being properly updated.

#2325 2325

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

…n a new private method in toga core, then updated the backends to call the new core method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant