modified invokation order of TextInput on_change and validation withi… #2594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a new private method in toga core, then updated the backends to call the new core method
I updated the invocation order of _validate() and on_change() in toga core and the appropriate backends where on_change() is validated for TextInputs. I did this by creating a new private method within the TextInput class named
_value_changed
and switched the call order between _validate and on_change. Then I attempted to add to existing test code to validate the _value_changed method. But I was not able to update any documentation reflecting the change.fixes issue where validation was called before a text change was recognized, thus preventing certain fields from being properly updated.
#2325 2325
PR Checklist: