Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure menu creation sequence is consistent. #2619

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Ensure menu creation sequence is consistent. #2619

merged 5 commits into from
Jun 11, 2024

Conversation

freakboy3742
Copy link
Member

The existing app startup sequence is inconsistent between platforms, as it doesn't guarantee:

  1. That system-installed app commands are installed before startup() is invoked
  2. That the change listener is added to the command list after commands have been fully created
  3. That menus are created after the initial menu state has been established.

Derived from #2244.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith June 7, 2024 03:57
This was referenced Jun 7, 2024
Closed
Merged
@mhsmith mhsmith merged commit 570ea88 into beeware:main Jun 11, 2024
31 of 34 checks passed
@freakboy3742 freakboy3742 deleted the app-startup-sequence branch June 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsmith mhsmith mhsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freakboy3742 @mhsmith