Replacing lru_cache with cache, post-3.8 #2912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Toga's dropping 3.8 support, I remembered a spot in
images
where I usedfunctools.lru_cache
becausecache
wasn't added until 3.9.From the docs on
cache
:So in that case it's a one-to-one swap. But I noticed one other place too, in
platform
. There it'smaxsize=1
instead ofNone
, which could behave differently — only keeping the most recent call instead of all calls — except thatget_platform_factory()
accepts no arguments, so it can only ever cache one value anyway. So setting it toNone
makes the result potentially smaller and faster without changing behavior, and that in turn is the same ascache
.PR Checklist: