Fix batch #57
Merged
Fix batch #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflow-v3-transitions
…orkflow-v3-content # Conflicts: # administrator/components/com_content/src/Model/ArticleModel.php
…orkflow-v3-content # Conflicts: # administrator/components/com_content/src/View/Featured/HtmlView.php # administrator/components/com_content/tmpl/articles/default.php
…orkflow-v3-content # Conflicts: # administrator/components/com_content/src/Model/ArticleModel.php # administrator/components/com_content/tmpl/articles/default.php # administrator/components/com_content/tmpl/featured/default.php # libraries/src/Workflow/Workflow.php
HLeithner
reviewed
Apr 21, 2020
| $user = Factory::getApplication()->getIdentity(); | ||
| /** @var $workflow */ |
| @@ -42,7 +45,7 @@ | |||
| <?php echo LayoutHelper::render('joomla.html.batch.tag', []); ?> | |||
| </div> | |||
| </div> | |||
| <?php if ($user->authorise('core.admin', 'com_content')) : ?> | |||
There was a problem hiding this comment.
I think that's the wrong approach, you should ask the service if the workflow is enabled for this view. Also as example for other developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required