Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow v3 transitions #61

Merged
merged 22 commits into from
Apr 21, 2020
Merged

Workflow v3 transitions #61

merged 22 commits into from
Apr 21, 2020

Conversation

bembelimen
Copy link
Owner

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

…orkflow-v3-transitions

# Conflicts:
#	libraries/src/Form/Field/TransitionField.php
…v3-transitions

# Conflicts:
#	modules/mod_stats/src/Helper/StatsHelper.php
…orkflow-v3-transitions

# Conflicts:
#	administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-05-15.sql
Fix support check for workflow publishing plugin
Secure controller execution for runTransition
@bembelimen bembelimen merged commit 12ca6b2 into workflow-v3 Apr 21, 2020
@bembelimen bembelimen deleted the workflow-v3-transitions branch April 21, 2020 23:01
bembelimen pushed a commit that referenced this pull request Dec 7, 2020
Change "Google Fonts" to "Font Schemes", multiple enhancements and clean up
- Remove previosly added local fonts.
- Do not use `build/media_source/fonts` and `media/fonts` anymore.
- Only use local fonts which are already available in the core - currently this is only Roboto, which is used by Atum and comes as NPM dependency).
- Add back the possibility to use fonts from web.
- Add 2 font schemes using Google Fonts from web for testing the new design.
- Use CSS variables to set font families and weights for headings and body - more variables might be added later with this PR or future PR while the final design is being implemented.
- Simplify UX: Only one grouped list field for selecting the font schemes or no font scheme, ie no need to first switch it on with one switcher and then in another field selecting the font scheme, it can be done in one step now.
- Remove the description from the remaining field.
- Show a warning note about possible GDPR issues with fonts from web and possible performance issues with fonts from local folders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant