Use old pseudo-nulldates in 4.0.0-2018-05-15.sql #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bembelimen
pushed a commit
that referenced
this pull request
Dec 7, 2020
The intention of this PR is to make a separate Metismenu, with real words in Menu Items. It lets the old menu Items untouched and makes testing easier for rtl. Additionally some houskeeping was made, typos fixed, hard coded item_ids replaced by the correct ItemIds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
In the update sql scripts 4.0.0-2018-05-15.sql, the old pseudo nulldates have to be used for the checked out time columns of the extensions tabnle, because this column is changed to real null dates with another update SQL which runs later.
This could have been seen easily in the diff of the workflow-v3 branch to the 4.0-dev branch of the cms, here e.g. for MySQL:
If this is not fixed, updates to J4 with the new workflow will fail at an early stage with SQL error, and the result will be corrupted data, i.e. some 10% updated and the rest still old J3.