exception handler draft #1

benedikt-bartscher · 2024-02-19T17:01:18Z

No description provided.

coderabbitai · 2024-02-19T17:01:33Z

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

benedikt-bartscher

Thanks Riyad, you are on the right track!

Btw, this part only takes care of exceptions thrown by event handlers. Client errors like in rx.call_script are still not handled. However, that's not as trivial to implement. If you want to collect some bonus points, also catch those errors and send them back to the backend. If you do not fully understand this, no worries, I am always here to answer all your questions or create an example for you.

reflex/app.py

reflex/state.py

reflex/utils/exceptions.py

benedikt-bartscher · 2024-02-19T17:10:43Z

reflex/state.py

+
+    @classmethod
+    def _handle_exception(cls, exception):
+        if cls._exception_handler:


You should add a default exception handler which replicates the old behavior (just print() errors) and drop this check

benedikt-bartscher · 2024-02-19T17:18:18Z

Btw @tanvirriyad please also take a look on those failing tests (pre-commit and unit-tests). The benchmarking job is expected to fail

… exception is added

…n handling

tanvir-riyad · 2024-02-20T10:54:52Z

Btw @tanvirriyad please also take a look on those failing tests (pre-commit and unit-tests). The benchmarking job is expected to fail

I looked at pre-commit failure. It happened for some docstring issues. I updated those. One unit test is failing because of return type issues.

tanvir-riyad · 2024-02-20T12:25:46Z

Thanks Riyad, you are on the right track!

Btw, this part only takes care of exceptions thrown by event handlers. Client errors like in rx.call_script are still not handled. However, that's not as trivial to implement. If you want to collect some bonus points, also catch those errors and send them back to the backend. If you do not fully understand this, no worries, I am always here to answer all your questions or create an example for you.

I have a small question regarding rx.call_script(). this function executes front-end code, right? when a user writes frontend code, they would be able to pass a custom exception handler as an argument like rx.App()?

benedikt-bartscher · 2024-02-20T12:40:53Z

Thanks Riyad, you are on the right track!
Btw, this part only takes care of exceptions thrown by event handlers. Client errors like in rx.call_script are still not handled. However, that's not as trivial to implement. If you want to collect some bonus points, also catch those errors and send them back to the backend. If you do not fully understand this, no worries, I am always here to answer all your questions or create an example for you.

I have a small question regarding rx.call_script(). this function executes front-end code, right? when a user writes frontend code, they would be able to pass a custom exception handler as an argument like rx.App()?

I wanted to review your changes later this evening, but since you seem to be interested in the rx.call_script exception handling, I will give you some hints.
Here are the related reflex docs: https://reflex.dev/docs/api-reference/browser_javascript/#inline-scripts
rx.call_script is used to trigger JavaScript execution from the backend. You can use it in event handlers, reflex then sends the script over websockets to the client and executes it.
That's why your implementation will not work. There are no python exceptions to try/catch, the exceptions happen in the client's browser.

This is an example reflex app which throws such an error in the frontend. You can just run it, open your chrome dev tools and checkout the JS console while pressing the test button.

import reflex as rx


class State(rx.State):
    def test_handler(self):
        print("test_handler called")
        yield rx.call_script("error")


def index() -> rx.Component:
    return rx.button(
        "Test",
        on_click=State.test_handler,  # type: ignore
    )


app = rx.App()
app.add_page(index)

As already mentioned the implementation is not trivial, you would have to send this error to the backend and pass it to the exception handler there.

…ch frontend exception

reflex/event.py

@@ -668,19 +667,23 @@ def call_script(
        callback_kwargs = {
            "callback": f"({arg_name}) => queueEvents([{format.format_event(event_spec)}], {constants.CompileVars.SOCKET})"
        }
+    wrapped_code = f"""


tanvirriyad added 2 commits February 19, 2024 17:42

added custom exception handler

49e8eee

added comment in exceptions.py

8082062

benedikt-bartscher commented Feb 19, 2024

View reviewed changes

tanvirriyad added 4 commits February 20, 2024 11:02

exception_handler added as rx.App attribute

81df285

app instance is used to get exception_handler and default behavior of…

5604454

… exception is added

added exception_handler for rx.call_script() for client side exceptio…

a0382ac

…n handling

ExceptionHandler class removed from exceptions.py

047b283

removed exception handler from call_script and try/catch added to cat…

4613033

…ch frontend exception

tanvir-riyad reviewed Feb 20, 2024

View reviewed changes

reflex/event.py

@@ -668,19 +667,23 @@ def call_script(

callback_kwargs = {

"callback": f"({arg_name}) => queueEvents([{format.format_event(event_spec)}], {constants.CompileVars.SOCKET})"

}

wrapped_code = f"""

This comment was marked as resolved.

Sign in to view

tanvirriyad added 7 commits February 22, 2024 13:47

wrapped_code removed

bc72f19

js try/catch & queueEvents added

f44c0bc

error event created

9ae325c

on_error added to add_page to pass custom exception handler

c7ee5d1

removed line

9876207

fixed error handler

1e0948f

test added for custom exception handler

b418b21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exception handler draft #1

exception handler draft #1

benedikt-bartscher commented Feb 19, 2024 •

edited

Loading

coderabbitai bot commented Feb 19, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

benedikt-bartscher left a comment

benedikt-bartscher Feb 19, 2024

benedikt-bartscher commented Feb 19, 2024

tanvir-riyad commented Feb 20, 2024

tanvir-riyad commented Feb 20, 2024

benedikt-bartscher commented Feb 20, 2024 •

edited

Loading

This comment was marked as resolved.

exception handler draft #1

Are you sure you want to change the base?

exception handler draft #1

Conversation

benedikt-bartscher commented Feb 19, 2024 • edited Loading

coderabbitai bot commented Feb 19, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

benedikt-bartscher left a comment

Choose a reason for hiding this comment

benedikt-bartscher Feb 19, 2024

Choose a reason for hiding this comment

benedikt-bartscher commented Feb 19, 2024

tanvir-riyad commented Feb 20, 2024

tanvir-riyad commented Feb 20, 2024

benedikt-bartscher commented Feb 20, 2024 • edited Loading

This comment was marked as resolved.

benedikt-bartscher commented Feb 19, 2024 •

edited

Loading

coderabbitai bot commented Feb 19, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

benedikt-bartscher commented Feb 20, 2024 •

edited

Loading