Fixed flow types imports

[syymza]

#1057 has fixed #921 for the basic case, in which an import is the only thing imported from a specific file.
Sometimes types and functions/classes need to be imported from the same file. This PR fixes also that specific instance:

import  { type MyOpaqueType, MyClass } from "./flowtypes"',

I have added some tests for all these cases

Fixes #1115.

[coveralls]

Coverage increased (+2.8%) to 97.268% when pulling 1d9ae51 on syymza:flow-types-fix into ebafcbf on benmosher:master.

[ljharb]

LGTM

[ljharb]

space after if?

[syymza]

added

[benmosher]

can you add a test that

import  { type MyOpaqueType, MyMissingClass } from "./flowtypes"

reports for only MyMissingClass?

[benmosher]

is this importKind test from line 15 needed anymore, after your change?

if (node.source == null || node.importKind === 'type') return

https://github.com/benmosher/eslint-plugin-import/pull/1106/files#diff-ff17d5a6c266bff5df3b40f4f70afc5aR15

if not, would like to get it out of there as your change seems more targeted and sufficient on its own.

[syymza]

@benmosher Added the requested test.
node.importKind === 'type' checks the imports having the type word outside of the {} specs. For this reason it cannot be removed, otherwise the other tests I have added in this PR will fail

[syymza]

🙄

[fizwidget]

Hey @benmosher, could you take another look at this one when you get a chance? Would love to see it merged 🙂

tests added

[bstuff]

Does this work when there are comments in imported module like:
foo.js:

/* flow-include
  export type Foo = string | number;
*/

bar.js:

import { type Foo } from './foo';

?

[ljharb]

@bstuff not sure; can you file a new issue if it doesn’t work?

[syymza]

@bstuff it should :)