Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignorePackages to produce errors #1521

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Fix ignorePackages to produce errors #1521

merged 1 commit into from
Dec 5, 2019

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Oct 28, 2019 •
edited
Loading

Closes #1518

@ljharb By "never" I mean literally never, even the test produced zero error before fixing buildProperties(). (I found this in https://github.com/w3c/respec/pull/2555)

@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 96.321% when pulling 568ca43 on saschanaz:ignorePackages into fb8ae71 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.1%) to 92.39% when pulling 2bfd9d0 on saschanaz:ignorePackages into 112a0bf on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.1%) to 92.39% when pulling 2bfd9d0 on saschanaz:ignorePackages into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.1%) to 92.39% when pulling 2bfd9d0 on saschanaz:ignorePackages into 112a0bf on benmosher:master.

@ljharb ljharb merged commit 568ca43 into import-js:master Dec 5, 2019
@saschanaz saschanaz deleted the ignorePackages branch December 5, 2019 23:59
@thewilkybarkid thewilkybarkid mentioned this pull request Dec 9, 2019
Closed
@ljharb ljharb mentioned this pull request Dec 9, 2019
Closed
@pcorpet pcorpet mentioned this pull request Dec 11, 2019
Closed
@quiqueg quiqueg mentioned this pull request Dec 11, 2019
Closed
@LasaleFamine LasaleFamine mentioned this pull request Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No errors when "import/extensions": ["error", "ignorePackages"]
3 participants
@saschanaz @coveralls @ljharb