New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): upgrade to eslint@4 #871

Merged

benmosher merged 1 commit into import-js:master from mastilver:upgrade-to-eslint-4

Jun 23, 2017

Contributor

mastilver commented Jun 12, 2017

close #870

mastilver force-pushed the upgrade-to-eslint-4 branch 2 times, most recently from a93d90e to 3f8bfdf Compare

June 12, 2017 13:31

coveralls commented Jun 12, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

coveralls commented Jun 12, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

coveralls commented Jun 12, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

corbinu reviewed

View reviewed changes

corbinu left a comment

peerDependencies also needs to be updated to allow for eslint 4

mastilver force-pushed the upgrade-to-eslint-4 branch 2 times, most recently from f5dbba8 to 2181590 Compare

June 12, 2017 15:27

coveralls commented Jun 12, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling f5dbba8 on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

1 similar comment

coveralls commented Jun 12, 2017

Coverage remained the same at 95.157% when pulling f5dbba8 on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

mastilver force-pushed the upgrade-to-eslint-4 branch from 2181590 to 42b1277 Compare

June 13, 2017 09:01

Contributor Author

mastilver commented Jun 13, 2017

The failing tests are also failing on master, I will try to find what's going on

I would like to get some help to apply the same logic for appveyor as I did for travis! :)

mastilver force-pushed the upgrade-to-eslint-4 branch from 42b1277 to d6be911 Compare

June 13, 2017 21:34

ljharb mentioned this pull request

eslint v4 support airbnb/javascript#1447

Closed

6 tasks

ShayDavidson commented Jun 15, 2017

Hey, any update on this? Thanks!

Contributor

Arcanemagus commented Jun 15, 2017

@mastilver For AppVeyor you will need to put each of the 6 combinations as individual groups in the environment matrix, so something like this:

environment:
  matrix:
    - nodejs_version: "7"
      ESLINT_VERSION: "4"

    - nodejs_version: "7"
      ESLINT_VERSION: "3"

    - nodejs_version: "7"
      ESLINT_VERSION: "2"

    - nodejs_version: "6"
      ESLINT_VERSION: "4"

    - nodejs_version: "6"
      ESLINT_VERSION: "3"

    - nodejs_version: "6"
      ESLINT_VERSION: "2"

Note also that it seems npm v3 is being forcibly installed for some reason, possibly an artifact from when Node.js v0.10 was still supported. As this is a downgrade for both of those versions of Node.js this should probably be removed unless it is still testing something relevant.

Member

ljharb commented Jun 15, 2017

npm 3 is absolutely still supported, as is npm 2, because that's what node 4 and 6 ship with.

That said, we shouldn't be forcibly installing an older version of npm.

lukekarrys mentioned this pull request

Update eslint to the latest version 🚀 lukekarrys/eslint-config#45

Merged

mysticatea mentioned this pull request

ESLint 4 mysticatea/eslint-config#5

Closed

1 task

alexander-akait commented Jun 16, 2017

/cc @mastilver friendly ping

Contributor Author

mastilver commented Jun 16, 2017

@evilebottnawi Yeah, I know... :)

I need to allocate more time for it, I will continue tonight or Sunday
In the meantime if someone want to take over feel free or ping me and I'll add you to the fork

rayrutjes mentioned this pull request

eslint-plugin-import unmet peer dependency algolia/eslint-config-algolia#37

Closed

mastilver force-pushed the upgrade-to-eslint-4 branch 3 times, most recently from 72472fd to eec46df Compare

June 17, 2017 14:27

coveralls commented Jun 17, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling 72472fd on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

coveralls commented Jun 17, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling eec46df on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

mastilver force-pushed the upgrade-to-eslint-4 branch from eec46df to ca8c28b Compare

June 17, 2017 14:51

coveralls commented Jun 17, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling eec46df on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

coveralls commented Jun 17, 2017 •

edited

Loading

Coverage remained the same at 95.157% when pulling ca8c28b on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

coveralls commented Jun 22, 2017

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

5 similar comments

coveralls commented Jun 22, 2017

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

coveralls commented Jun 22, 2017

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

coveralls commented Jun 22, 2017

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

Member

benmosher commented Jun 22, 2017 •

edited

Loading

remove eslint matrix for appveyor and just keep the node matrix

sounds good to me 👍🏻

ljharb approved these changes

View reviewed changes

Contributor

Arcanemagus commented Jun 22, 2017

Looks like the failing Travis CI build is on a test that normally takes a while to run, as that specific job was the longest running is that an intermittent failure on the slower OS X hosts?

mastilver force-pushed the upgrade-to-eslint-4 branch 2 times, most recently from 528fc71 to 4c52e1a Compare

June 22, 2017 18:01


          chore(eslint): upgrade to eslint@4

a8ca5bb

mastilver force-pushed the upgrade-to-eslint-4 branch from 4c52e1a to a8ca5bb Compare

June 22, 2017 18:02

benmosher self-requested a review

June 22, 2017 18:27

benmosher approved these changes

View reviewed changes

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling 4c52e1a on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

1 similar comment

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling 4c52e1a on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

Contributor Author

mastilver commented Jun 22, 2017

@benmosher I think it would be handy to enable Auto cancel pull request builds on travis

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling a8ca5bb on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

coveralls commented Jun 22, 2017 •

edited

Loading

Coverage remained the same at 95.963% when pulling a8ca5bb on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

Member

benmosher commented Jun 23, 2017

Ah, neat. I didn't even know that was an option, thanks! And great work! 🎉🙏🏻🎉

benmosher merged commit 7f055ec into import-js:master

Contributor

lukeapage commented Jun 23, 2017

@benmosher please can we have a new release to unblock using eslint 4?

Member

ljharb commented Jun 23, 2017

@lukeapage #870 (comment) please be patient. Using eslint 4 isn't urgent :-)

Contributor

lukeapage commented Jun 23, 2017

Sorry should have checked the issue, I thought it had just been forgotten.

mastilver deleted the upgrade-to-eslint-4 branch

June 23, 2017 09:25

Member

benmosher commented Jun 23, 2017

published 👍🏻

ljharb mentioned this pull request

Support eslint v4. jsx-eslint/eslint-plugin-jsx-a11y#267

Merged

This was referenced Apr 15, 2018

Update eslint-plugin-import to 2.12.0 sbardian/DebtTrackerAPI#25

Merged

Update dependency eslint-plugin-import to v2.11.0 Urigo/tortilla#68

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet