From 6f7bf8adfdc3eba0223e2d8050c5a66d2f09c0dc Mon Sep 17 00:00:00 2001
From: "Ben Sheldon [he/him]" <bensheldon@gmail.com>
Date: Sun, 30 Jan 2022 07:57:30 -0800
Subject: [PATCH] Guard LogSubscriber against tagged logger with absent
 formatter

---
 lib/good_job/log_subscriber.rb           |  2 +-
 spec/lib/good_job/log_subscriber_spec.rb | 40 ++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 1 deletion(-)
 create mode 100644 spec/lib/good_job/log_subscriber_spec.rb

diff --git a/lib/good_job/log_subscriber.rb b/lib/good_job/log_subscriber.rb
index fc09e40a7..2e8620fda 100644
--- a/lib/good_job/log_subscriber.rb
+++ b/lib/good_job/log_subscriber.rb
@@ -206,7 +206,7 @@ def tag_logger(*tags, &block)
       good_job_tag = ["ActiveJob"].freeze
 
       self.class.loggers.inject(block) do |inner, each_logger|
-        if each_logger.respond_to?(:tagged)
+        if each_logger.respond_to?(:tagged) && each_logger.formatter
           tags_for_logger = if each_logger.formatter.current_tags.include?("ActiveJob")
                               good_job_tag + tags
                             else
diff --git a/spec/lib/good_job/log_subscriber_spec.rb b/spec/lib/good_job/log_subscriber_spec.rb
new file mode 100644
index 000000000..a06a984b9
--- /dev/null
+++ b/spec/lib/good_job/log_subscriber_spec.rb
@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+require 'rails_helper'
+
+RSpec.describe GoodJob::LogSubscriber do
+  let(:subscriber) { described_class.new }
+
+  around do |example|
+    orig_loggers = described_class.loggers.dup
+    described_class.loggers.clear
+    described_class.reset_logger
+
+    example.run
+
+    described_class.loggers.replace(orig_loggers)
+    described_class.reset_logger
+  end
+
+  describe "loggers" do
+    let(:logs) { StringIO.new }
+
+    it 'logs output with a simple logger' do
+      described_class.loggers << Logger.new(logs)
+      event = ActiveSupport::Notifications::Event.new("", nil, nil, "id", {})
+
+      subscriber.scheduler_create_pool(event)
+      expect(logs.string).to include("GoodJob started scheduler with queues= max_threads=")
+    end
+
+    it 'logs output with a tagged logger with missing formatter' do
+      logger = ActiveSupport::TaggedLogging.new(Logger.new(logs))
+      logger.formatter = nil
+      described_class.loggers << logger
+
+      event = ActiveSupport::Notifications::Event.new("", nil, nil, "id", {})
+
+      subscriber.scheduler_create_pool(event)
+      expect(logs.string).to include("GoodJob started scheduler with queues= max_threads=")
+    end
+  end
+end