Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43: Changes to the top banner #14

Merged
merged 4 commits into from
Dec 31, 2021
Merged

Conversation

juanpabloventoso
Copy link
Contributor

  • Updated the store and navigationGuard scripts to handle login and logout operations differently, allowing to automatically login as a guest after logout
  • Added a new refresh icon next to the pseudonym value on the top banner when the user is a guest, in order to create a new pseudonym
  • Added a close icon to the delete modal popup and updated the layout as discussed on the standup meeting
  • Added a new function to calculate the pseudonym select width based on its content and calling the new function after the page has been loaded in addition to the select change event
  • Fixed a bug that prevented the pseudonym select to adjust automatically when creating a new pseudonym
  • Added a hint message to the Create new pseudonym button when the max allowed pseudonyms were reached

@bimalghartimagar
Copy link
Contributor

Reviewed and tested changes. Looks good. Thanks Juan.

@bimalghartimagar bimalghartimagar merged commit 4d0f12f into dev Dec 31, 2021
@bimalghartimagar bimalghartimagar deleted the 43-changes-to-the-top-banner branch December 31, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants