Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not install with nodejs 20 (@azure/msal-node issue) #77

Closed
colinl opened this issue Jul 17, 2023 · 10 comments
Closed

Does not install with nodejs 20 (@azure/msal-node issue) #77

colinl opened this issue Jul 17, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request upstream Waiting for upstream changes / fixes

Comments

@colinl
Copy link

colinl commented Jul 17, 2023

Version 0.10.2 will not install with nodejs 20.4.0 on Ubuntu 20.04. The dependency @azure/msal-node requires nodejs 10,12,14,16 or 18. The error when attempting to install is

~/.node-red$ npm install node-red-contrib-mssql-plus
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@azure/msal-node@1.18.0',
npm WARN EBADENGINE   required: { node: '10 || 12 || 14 || 16 || 18' },
npm WARN EBADENGINE   current: { node: 'v20.4.0', npm: '9.7.2' }
npm WARN EBADENGINE }

@jfaigan
Copy link

jfaigan commented Aug 21, 2023

FYI, I am having the same issue.
image

@jfaigan
Copy link

jfaigan commented Aug 21, 2023

I was able to bypass the issue by manually installing the npm package and omitting the --engine-strict flag

npm install --no-audit --no-update-notifier --no-fund --save --save-prefix=~ --production node-red-contrib-mssql-plus@0.10.2

@Steve-Mcl
Copy link
Collaborator

@azure/msal-node is a grandchild dependancy of mssql (mssql -> tedious -> i_forget_what_this_one_is -> @azure/msal-node

@azure/msal-node is currently at v 2.1.0 and DOES support node 20

It may be this packages dependency mssql needs updating to v10.0.0 (or perhaps 9.3.2) to get the problematic sub dependency @azure/msal-node up to v2.x)

@bestlong do you have time to look into this?

bestlong added a commit that referenced this issue Sep 13, 2023
@bestlong bestlong self-assigned this Sep 13, 2023
@bestlong
Copy link
Owner

@colinl
try npm i node-red-contrib-mssql-plus@0.11.0-beta

@bestlong bestlong reopened this Oct 1, 2023
@bestlong
Copy link
Owner

bestlong commented Oct 1, 2023

about tedious depandency package @azure/msal-node

1.18.3 support

  "engines": {
    "node": "10 || 12 || 14 || 16 || 18"
  }

^2.0.0 support

  "engines": {
    "node": "18 || 20"
  }

upgrade is not good decision

suggest downgrade use nodejs latest LTS version.

@bestlong bestlong closed this as completed Oct 1, 2023
@colinl
Copy link
Author

colinl commented Oct 1, 2023

Sorry, I did not receive a notification of your earlier message asking me to try the beta version.
Nodejs 20 is overdue to become the current LTS (https://nodejs.dev/en/about/releases/) so presumably it will be announced as LTS very soon.
You could release your node as a new major version, requiring 18 or 20.

@bestlong bestlong reopened this Oct 6, 2023
@bestlong bestlong added enhancement New feature or request upstream Waiting for upstream changes / fixes labels Oct 6, 2023
@bestlong
Copy link
Owner

bestlong commented Oct 6, 2023

wait tediousjs/tedious#1575 PR merge

@Steve-Mcl
Copy link
Collaborator

This is long since resolved as far as I can see?

@colinl
Copy link
Author

colinl commented Jun 18, 2024

Don't the dependencies need to be updated to make sure that the later version of tedious is installed if a user upgrades this node to the latest version? Otherwise it is necessary to uninstall this node and re-install it again.

@Steve-Mcl
Copy link
Collaborator

Yes, and that will happen (soon), but for now semver will do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Waiting for upstream changes / fixes
Projects
None yet
Development

No branches or pull requests

4 participants