Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-dns: update for latest ecosystem and convention changes #251

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

balupton
Copy link
Member

@balupton balupton commented Sep 17, 2024

general fixes:

general changes and improvements:

  • echo-mkdirp: support quiet
  • eval-helper: rewrote quiet/verbose handling and improved performance, added --trim option for use by is-dns-working, and renamed --title=<title> to --command=<command-string> used by sudo-helper
  • git-helper, setup-dns: use test ! -s <file> instead of test -z "$(cat <file>)"
  • is-internet-working: rewrote, with improved --quiet handling
  • add is-dns-working to partner is-internet-working
  • service-helper: rewrote where action invocation is now cycled by action provision, also fixed unloading
  • setup-environment-commands: add BIN_DIR, CONF_DIR, DATA_DIR, LIB_DIR, STATE_DIR, SERVICE_DIR, LOGS_DIR
  • setup-mac-brew: added a 'try again" note regarding upgrade failures
  • setup-util-plex renamed to `setup-util-plex-media-server
  • setup-util: add --installed and --uninstalled aliases
  • styles.bash: add code-good1 styles, add fragment styles

setup-dns changes and improvements:

  • setup-dns: /close Suggestion: simplify setup-dns #221
    • made mono-function again, and cleaned up code
    • rewrote for modern conventions, fixed support of adguard-home, dnscrypt-proxy, and cloudflared on macos
    • now uses a new dns.json configuration for configuring services and providers, this adds descriptions for selection, and also added dnscrypt_names for quad9
  • added setup-util-(adguard-home|cloudflared|dnscrypt-proxy) which are aliases for their setup-dns setups

todos:

  • setup-dns:
    • consider a multi choose menu for --install/--uninstall/--disable
    • test on linux

commits:

@balupton balupton self-assigned this Sep 17, 2024
@balupton balupton force-pushed the dev/setup-dns branch 2 times, most recently from 2e38cec to 53f483e Compare September 23, 2024 01:45
/ref #221

- `dorothy-workflow.yml`: add latest images
- `echo-mkdirp`: support quiet
- `setup-dns`: made mono-function again, and cleaned up code
- `setup-environment-commands`: add `STATE_DIR`
- `setup-util`: add `--installed` and `--uninstalled` aliases
- `setup-util-(adguard-home|cloudflared|dnscrypt-proxy)`: now just aliases for `setup-dns`
- `setup-util-plex` renamed to `setup-util-plex-media-server`
- `dns.json` move `about` before `url`, and remove `local` as that is a programmatic provider
- setup-dns: rewrote for modern conventions, fixed support of `adguard-home`, `dnscrypt-proxy`, and `cloudflared` on macos
- eval-helper: rewrote quiet/verbose handling and improved performance, added `--trim` option, and renamed `--title=<title>` to `--command=<command-string>` (updated `sudo-helper` usage)
- git-helper, setup-dns: use `test ! -s <file>` instead of `test -z "$(cat <file>)"`
- setup-mac-brew: added 'try again" about upgrade failures
- is-internet-working: rewrote, with improved `--quiet` handling
- add `is-dns-working` to partner `is-internet-working`
- dns.json: add `dnscrypt_names` for quad9
- styles.bash: add `code-good1` styles, add fragment styles

dev fixes:

- service-helper: fix unload, fix linting, fix invalid var
- setup-dns: fix json mismatch due to `keys` being sorted

todos:

- setup-dns: multi choose menu for `--install`/`--uninstall`/`--disable`
- setup-dns: test on linux
@balupton balupton changed the title WIP: initial work to simplify setup-dns setup-dns: update for latest ecosystem and convention changes Sep 30, 2024
@balupton balupton merged commit d17514e into master Sep 30, 2024
21 of 23 checks passed
@balupton balupton deleted the dev/setup-dns branch October 1, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multiline choose labels are missing blockquote in linger Suggestion: simplify setup-dns
1 participant