Skip to content

Commit

Permalink
bevy_reflect: Remove U32Visitor (#12433)
Browse files Browse the repository at this point in the history
# Objective

The `U32Visitor` struct has been unused since its introduction in #6140.
It's made itself known now by causing a recent [CI
failure](https://github.com/bevyengine/bevy/actions/runs/8243333274/job/22543736624).

## Solution

Remove the unused `U32Visitor` struct.

Also removed `PrepassLightsViewFlush` as it was causing a [similar CI
failure](https://github.com/bevyengine/bevy/actions/runs/8243838066/job/22545103746?pr=12433#step:6:269)
on this PR.
  • Loading branch information
MrGVSV authored Mar 12, 2024
1 parent c729859 commit 4c47e31
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
3 changes: 0 additions & 3 deletions crates/bevy_pbr/src/prepass/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,3 @@ pub type DrawPrepass<M> = (
SetMaterialBindGroup<M, 2>,
DrawMesh,
);

#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
struct PrepassLightsViewFlush;
17 changes: 0 additions & 17 deletions crates/bevy_reflect/src/serde/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -240,23 +240,6 @@ impl<'de> Deserialize<'de> for Ident {
}
}

struct U32Visitor;

impl<'de> Visitor<'de> for U32Visitor {
type Value = u32;

fn expecting(&self, formatter: &mut Formatter) -> fmt::Result {
formatter.write_str("u32")
}

fn visit_u32<E>(self, v: u32) -> Result<Self::Value, E>
where
E: Error,
{
Ok(v)
}
}

/// A general purpose deserializer for reflected types.
///
/// This will return a [`Box<dyn Reflect>`] containing the deserialized data.
Expand Down

0 comments on commit 4c47e31

Please sign in to comment.