From aeaef2d8cd389e14066f45f2f6dd6a3ca6f8337b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9l=C3=A8ne=20Amanita?= Date: Fri, 21 Jul 2023 09:02:03 +0100 Subject: [PATCH] HalfSpace is actually an open set --- crates/bevy_render/src/primitives/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/bevy_render/src/primitives/mod.rs b/crates/bevy_render/src/primitives/mod.rs index 9877e2a07a9de..f6e3cff7b3649 100644 --- a/crates/bevy_render/src/primitives/mod.rs +++ b/crates/bevy_render/src/primitives/mod.rs @@ -106,9 +106,9 @@ impl Sphere { } } -/// A region of 3D space, specifically a closed set whose border is a bisecting 2D plane. +/// A region of 3D space, specifically an open set whose border is a bisecting 2D plane. /// This bisecting plane partitions 3D space into two infinite regions, -/// the half-space is one of those regions and includes the bisecting plane. +/// the half-space is one of those regions and excludes the bisecting plane. /// /// Each instance of this type is characterized by: /// - the bisecting plane's unit normal, normalized and pointing "inside" the half-space, @@ -120,7 +120,7 @@ impl Sphere { /// /// Any point `p` is considered to be within the `HalfSpace` when the length of the projection /// of p on the normal is greater or equal than the opposite of the distance, -/// meaning: if the equation `normal.dot(p) + distance >= 0.` is satisfied. +/// meaning: if the equation `normal.dot(p) + distance > 0.` is satisfied. /// /// For example, the half-space containing all the points with a z-coordinate lesser /// or equal than `8.0` would be defined by: `HalfSpace::new(Vec3::NEG_Z.extend(-8.0))`.