From c245b1774328ef5a8ade9b423fcd937f720a1fe1 Mon Sep 17 00:00:00 2001 From: Larry Du Date: Tue, 25 Oct 2022 09:55:31 +0000 Subject: [PATCH] Revert thiserror version requirement to match version for all crates. (#6365) # Objective - Reverts unnecessary version increase for `thiserror` caused by the following PR. https://github.com/bevyengine/bevy/commit/9066d514208671d8c62031465dea5eb977c51e25 - The aforementioned PR should have increased `thiserrror` version uniformly across all bevy crates. As far as I can tell it was unneccessary to bump versions ## Solution - Revert versions to the matching version used by other bevy "crates" ``` MBP-Larry-Du.local:~/Code/bevy:$ git grep thiserror CHANGELOG.md:- [Derive thiserror::Error for HexColorError][2740] crates/bevy_asset/Cargo.toml:thiserror = "1.0" crates/bevy_asset/src/asset_server.rs:use thiserror::Error; crates/bevy_asset/src/io/mod.rs:use thiserror::Error; crates/bevy_gltf/Cargo.toml:thiserror = "1.0" crates/bevy_gltf/src/loader.rs:use thiserror::Error; crates/bevy_input/Cargo.toml:thiserror = "1.0" crates/bevy_input/src/gamepad.rs:use thiserror::Error; crates/bevy_reflect/Cargo.toml:thiserror = "1.0" crates/bevy_reflect/src/path.rs:use thiserror::Error; crates/bevy_render/Cargo.toml:thiserror = "1.0" ``` --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. - What changed as a result of this PR? Fixed dependency conflict for building projects. Current build of StarRust runs successfully with the `thiserror` reversion: https://github.com/LarsDu/StarRust But will run into dependency conflicts if `thiserror` is version 1.037 Co-authored-by: Larry Du --- crates/bevy_ui/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/bevy_ui/Cargo.toml b/crates/bevy_ui/Cargo.toml index caf95361fdbad..987179a663379 100644 --- a/crates/bevy_ui/Cargo.toml +++ b/crates/bevy_ui/Cargo.toml @@ -34,4 +34,4 @@ taffy = "0.1.0" serde = { version = "1", features = ["derive"] } smallvec = { version = "1.6", features = ["union", "const_generics"] } bytemuck = { version = "1.5", features = ["derive"] } -thiserror = "1.0.37" +thiserror = "1.0.0"