Fix UB in relationship spawns

james7132 · james7132 · commit f797072b1567 · 2025-08-26T21:21:09.000-07:00
diff --git a/crates/bevy_ecs/src/spawn.rs b/crates/bevy_ecs/src/spawn.rs
@@ -331,6 +331,7 @@ impl<R: Relationship, B: Bundle> DynamicBundle for SpawnOneRelated<R, B> {
     ) {
         let mut target = <R::RelationshipTarget as RelationshipTarget>::with_capacity(1);
         <R::RelationshipTarget as DynamicBundle>::get_components(&mut target, func);
+        core::mem::forget(target);
     }
 
     unsafe fn apply_effect(ptr: *mut Self, entity: &mut EntityWorldMut) {

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,7 @@ impl<R: Relationship, B: Bundle> DynamicBundle for SpawnOneRelated<R, B> {`
`331`	`331`	`) {`
`332`	`332`	`let mut target = <R::RelationshipTarget as RelationshipTarget>::with_capacity(1);`
`333`	`333`	`<R::RelationshipTarget as DynamicBundle>::get_components(&mut target, func);`
	`334`	`+ core::mem::forget(target);`
`334`	`335`	`}`
`335`	`336`
`336`	`337`	`unsafe fn apply_effect(ptr: *mut Self, entity: &mut EntityWorldMut) {`