Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Regression from 0.5.0 to 0.8.0 #5510

Closed
spalfs opened this issue Jul 31, 2022 · 4 comments
Closed

Rendering Regression from 0.5.0 to 0.8.0 #5510

spalfs opened this issue Jul 31, 2022 · 4 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@spalfs
Copy link

spalfs commented Jul 31, 2022

versioning

bevy 0.8.0
archlinux 5.15.55-2-lts
rustc 1.62.1 (e092d0b6b 2022-07-16)
cargo 1.62.1 (a748cf5a3 2022-06-08)
2022-07-31T12:09:13.849899Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD RADV RAVEN", vendor: 4098, device: 5592, device_type: IntegratedGpu, backend: Vulkan }

testing

i ran various wgpu examples and didn't see the issue, although they don't have many sprite examples
i also tried the opengl backend renderer, and the issue was still there

how i got here

I made a sort of bejeweled demo back in 0.5.0, it didn't have this graphical artifact (see screenshots)
I now moved the codebase to using 0.8.0, and noticed there is a white line above the green gems but only sometimes.
in the spritesheet, there is a white sprite above the green gem, so I assume it is coming from that.
i have not changed much in how the spritesheet bundle operates.

the 0.5.0 code can be found here:
https://git.tombarrett.xyz/gems/log.html

and the 0.8.0 diff is here
https://pastebin.com/0BcK0XLS

0.5.0

2022-07-31-140350_3200x1080_scrot

0.8.0

2022-07-31-140138_3200x1080_scrot

@spalfs spalfs added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 31, 2022
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jul 31, 2022

Pretty sure this is a duplicate of #5266 :) See that thread for the fix.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jul 31, 2022
@adals
Copy link

adals commented Jul 31, 2022

for ref

also got it when run cargo run --release --example many_foxes

Screen Shot 2022-07-31 at 5 39 46 PM

@rparrett
Copy link
Contributor

I think that your issue is more like #1949 but that sort of thing is also present in 0.5.0, so that's curious.

If you don't have any padding in your sprite sheet, I'd add some and see if that fixes the issue.

You might also try setting the default filter mode to nearest.

The many_foxes issue is a separate thing: #5118

@spalfs
Copy link
Author

spalfs commented Jul 31, 2022

Pretty sure this is a duplicate of #5266 :) See that thread for the fix.

I already have .insert_resource(ImageSettings::default_nearest()) as when I didn't, the 2d pixels were very blurry.

also got it when run cargo run --release --example many_foxes

I just ran that and do have the same issue, but it seems a little different more related to textureatlases

I also have a build for 0.7.0 that has the same bug

I think that your issue is more like #1949 but that sort of thing is also present in 0.5.0, so that's curious.

oh this looks very similar, sorry for the repost must have missed it in my search

If you don't have any padding in your sprite sheet, I'd add some and see if that fixes the issue.

i figured I could give padding to fix it

thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

No branches or pull requests

4 participants