Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material trait doesn't mention that prepass shaders are used for shadow mapping #8696

Closed
Nathan-Fenner opened this issue May 28, 2023 · 0 comments · Fixed by #9025
Closed

Material trait doesn't mention that prepass shaders are used for shadow mapping #8696

Nathan-Fenner opened this issue May 28, 2023 · 0 comments · Fixed by #9025
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation
Milestone
0.12

Comments

@Nathan-Fenner
Copy link
Contributor

How can Bevy's documentation be improved?

The Material trait docs mention the prepass_vertex_shader and prepass_fragment_shader, but don't say explicitly what they're used for.

In particular, they don't mention that these shaders are used for shadow mapping. I only found this out because it's mentioned in #3755.
@Nathan-Fenner Nathan-Fenner added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels May 28, 2023
@JMS55 JMS55 added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels May 28, 2023
@JMS55 JMS55 added this to the 0.11 milestone May 28, 2023
@geieredgar geieredgar mentioned this issue Jul 2, 2023
Merged
@cart cart modified the milestones: 0.11, 0.12 Jul 9, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
@geieredgar
Explain usage of prepass shaders in docs for Material trait (#9025)
e23d7cf 
# Objective

- Fixes #8696.

## Solution

- Added a paragraph describing the usage of the `prepass_vertex_shader`
and `prepass_fragment_shader`.
ameknite pushed a commit to ameknite/bevy that referenced this issue Nov 6, 2023
@geieredgar @ameknite
Explain usage of prepass shaders in docs for Material trait (bevyen…
bc9fcab 
…gine#9025)

# Objective

- Fixes bevyengine#8696.

## Solution

- Added a paragraph describing the usage of the `prepass_vertex_shader`
and `prepass_fragment_shader`.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@geieredgar
Explain usage of prepass shaders in docs for Material trait (bevyen…
bb33cf0 
…gine#9025)

# Objective

- Fixes bevyengine#8696.

## Solution

- Added a paragraph describing the usage of the `prepass_vertex_shader`
and `prepass_fragment_shader`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

Explain usage of prepass shaders in docs for Material trait geieredgar/bevy
3 participants
@cart @Nathan-Fenner @JMS55