Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that gizmo depth_bias has no effect in 2D #10074

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

tim-blackbird
Copy link
Contributor

No description provided.

/// Value between -1 and 1 (inclusive).
/// * 0 means that there is no change to the line position when rendering
/// * 1 means it is furthest away from camera as possible
/// * -1 means that it will always render in front of other things.
///
/// This is typically useful if you are drawing wireframes on top of polygons
/// and your wireframe is z-fighting (flickering on/off) with your main model.
/// You would set this value to a negative number close to 0.0.
/// You would set this value to a negative number close to 0.
Copy link
Contributor Author

@tim-blackbird tim-blackbird Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency as the other numbers here don't use rust float notation either

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Gizmos Visual editor and debug gizmos labels Oct 10, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 10, 2023
@james7132 james7132 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into bevyengine:main with commit f8cbc73 Oct 11, 2023
25 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gizmos Visual editor and debug gizmos C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants