Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use read instead of deprecated iter #10376

Merged
merged 1 commit into from
Nov 5, 2023
Merged

docs: use read instead of deprecated iter #10376

merged 1 commit into from
Nov 5, 2023

Conversation

HeyZoos
Copy link
Contributor

@HeyZoos HeyZoos commented Nov 5, 2023

https://docs.rs/bevy/latest/bevy/ecs/event/struct.EventReader.html#method.iter

Objective

  • Remove doc example using deprecated EventReader.iter method

Solution

  • Update docs to use read instead of iter

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Time Involves time keeping and reporting labels Nov 5, 2023
@alice-i-cecile
Copy link
Member

Thanks!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 5, 2023
Merged via the queue into bevyengine:main with commit 32a5c7d Nov 5, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@HeyZoos @ameknite
docs: use read instead of deprecated iter (bevyengine#10376)
0f6f8d1 
https://docs.rs/bevy/latest/bevy/ecs/event/struct.EventReader.html#method.iter

# Objective

- Remove doc example using deprecated `EventReader.iter` method

## Solution

- Update docs to use `read` instead of `iter`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@HeyZoos
docs: use read instead of deprecated iter (bevyengine#10376)
db88113 
https://docs.rs/bevy/latest/bevy/ecs/event/struct.EventReader.html#method.iter

# Objective

- Remove doc example using deprecated `EventReader.iter` method

## Solution

- Update docs to use `read` instead of `iter`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeyZoos @alice-i-cecile @mockersf