Fix bevy_pbr shader function name #10423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
|
You can test the interaction between prepass and morph targets with this example file: https://gist.github.com/nicopap/bf97174f1496df4854909d672eb2cc0f Can you confirm it works? |
superdump
approved these changes
Nov 7, 2023
james7132
approved these changes
Nov 7, 2023
james7132
added
the
S-Ready-For-Final-Review
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Nov 13, 2023
# Objective Fix a shader error that happens when using pbr morph targets. ## Solution Fix the function name in the `prepass.wgsl` shader, which is incorrectly prefixed with `morph::` (added in bevyengine@61bad4e#diff-97e4500f0a36bc6206d7b1490c8dd1a69459ee39dc6822eb9b2f7b160865f49fR42). This section of the shader is only enabled when using morph targets, so it seems like there are no tests / examples using it?
cart
pushed a commit
that referenced
this pull request
Nov 30, 2023
# Objective Fix a shader error that happens when using pbr morph targets. ## Solution Fix the function name in the `prepass.wgsl` shader, which is incorrectly prefixed with `morph::` (added in 61bad4e#diff-97e4500f0a36bc6206d7b1490c8dd1a69459ee39dc6822eb9b2f7b160865f49fR42). This section of the shader is only enabled when using morph targets, so it seems like there are no tests / examples using it?
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Fix a shader error that happens when using pbr morph targets. ## Solution Fix the function name in the `prepass.wgsl` shader, which is incorrectly prefixed with `morph::` (added in bevyengine@61bad4e#diff-97e4500f0a36bc6206d7b1490c8dd1a69459ee39dc6822eb9b2f7b160865f49fR42). This section of the shader is only enabled when using morph targets, so it seems like there are no tests / examples using it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix a shader error that happens when using pbr morph targets.
Solution
Fix the function name in the
prepass.wgslshader, which is incorrectly prefixed withmorph::(added in 61bad4e#diff-97e4500f0a36bc6206d7b1490c8dd1a69459ee39dc6822eb9b2f7b160865f49fR42).This section of the shader is only enabled when using morph targets, so it seems like there are no tests / examples using it?