Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow #[derive(Bundle)] on tuple structs (take 3) #10561

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Allow #[derive(Bundle)] on tuple structs (take 3) #10561

merged 6 commits into from
Nov 21, 2023

Conversation

SET001
Copy link
Member

@SET001 SET001 commented Nov 14, 2023

@SET001 SET001 marked this pull request as draft November 14, 2023 22:32
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 14, 2023
@SET001 SET001 marked this pull request as ready for review November 14, 2023 22:42
nicopap
nicopap reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to move the test.

crates/bevy_ecs/src/bundle.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/macros/src/lib.rs Outdated Show resolved Hide resolved
@SET001 SET001 requested review from nicopap and MrGVSV November 16, 2023 21:39
@SET001
Copy link
Member Author

SET001 commented Nov 17, 2023

are there any places in docs that should be updated to these changes?

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 19, 2023
@alice-i-cecile
Copy link
Member

I would be happy to see this added to a doc test in the Bundle derive code, but that's definitely not blocking.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 21, 2023
Merged via the queue into bevyengine:main with commit eeb0c2f Nov 21, 2023
22 checks passed
@SET001 SET001 mentioned this pull request Nov 24, 2023
Closed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SET001
Allow #[derive(Bundle)] on tuple structs (take 3) (bevyengine#10561)
2b64d2a 
- rework of old @Veykril's work in
[2499](bevyengine#2499)
- Fixes [3537](bevyengine#3537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV Awaiting requested review from MrGVSV

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make #[derive(Bundle)] work on tuple structs
4 participants
@SET001 @alice-i-cecile @nicopap @MrGVSV