Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete methods deprecated in 0.12 #10693

Merged
merged 3 commits into from
Nov 24, 2023
Merged

delete methods deprecated in 0.12 #10693

merged 3 commits into from
Nov 24, 2023

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Nov 22, 2023 •
edited
Loading

Changelog

  • delete methods deprecated in 0.12

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Nov 22, 2023
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@alice-i-cecile
Copy link
Member

CI failures look real: it seems we were still using some of these internally.

@hymm hymm force-pushed the delete-deprecated branch from 96a0a9c to 629631f Compare November 22, 2023 17:38
@hymm hymm force-pushed the delete-deprecated branch from 40dbea3 to c79c24c Compare November 23, 2023 04:04
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 23, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 24, 2023
Merged via the queue into bevyengine:main with commit 11b1b3a Nov 24, 2023
23 checks passed
@hymm hymm deleted the delete-deprecated branch January 2, 2024 00:15
@rparrett rparrett mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoJoJet JoJoJet JoJoJet approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@hymm @alice-i-cecile @JoJoJet