Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl From<Color> for ClearColorConfig #10734

Merged
merged 2 commits into from
Nov 26, 2023
Merged

impl From<Color> for ClearColorConfig #10734

merged 2 commits into from
Nov 26, 2023

Conversation

torsteingrindvik
Copy link
Contributor

@torsteingrindvik torsteingrindvik commented Nov 25, 2023 •
edited
Loading

Objective

I tried setting ClearColorConfig in my app via Color::FOO.into() expecting it to work, but the impl was missing.

Solution

  • Add impl From<Color> for ClearColorConfig
  • Change examples to use this impl

Changelog

Added

  • ClearColorConfig can be constructed via .into() on a Color

Torstein Grindvik added 2 commits November 25, 2023 11:39
impl From<Color> for ClearColorConfig
0743729 
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
Clippy
6c4a179 
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 26, 2023
@james7132 james7132 added this pull request to the merge queue Nov 26, 2023
@james7132 james7132 added this to the 0.13 milestone Nov 26, 2023
Merged via the queue into bevyengine:main with commit 73bb310 Nov 26, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atornity atornity atornity approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
5 participants
@torsteingrindvik @james7132 @alice-i-cecile @mockersf @atornity