Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't run update before window creation in winit #10741

Merged
merged 1 commit into from
Nov 26, 2023
Merged

don't run update before window creation in winit #10741

merged 1 commit into from
Nov 26, 2023

Conversation

mockersf
Copy link
Member

Objective

Solution

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in labels Nov 25, 2023
@mockersf mockersf added this to the 0.12.1 milestone Nov 25, 2023
@cart cart added this pull request to the merge queue Nov 26, 2023
Merged via the queue into bevyengine:main with commit 89d652b Nov 26, 2023
25 checks passed
cart pushed a commit that referenced this pull request Nov 30, 2023
@mockersf @cart
don't run update before window creation in winit (#10741)
9cfc481 
# Objective

- Window size, scale and position are not correct on the first execution
of the systems
- Fixes #10407,  fixes #10642

## Solution

- Don't run `update` before we get a chance to create the window in
winit
- Finish reverting #9826 after #10389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.12.1
3 participants
@mockersf @cart @alice-i-cecile