Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Archetypes.archetype_component_count private #10774

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Make Archetypes.archetype_component_count private #10774

merged 1 commit into from
Feb 3, 2024

Conversation

stepancheg
Copy link
Contributor

Make more clear where it is used and how.

@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 28, 2023
alice-i-cecile
alice-i-cecile approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: this better captures the intent of how this API should be used.

@stepancheg stepancheg force-pushed the archetype-component-id branch from 4d6e2b1 to 6bd73cf Compare November 28, 2023 18:36
james7132
james7132 requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the number of stray pub(crate) fields in the ECS. This has been a long time coming. Just a few notes on documentation, and the one behavioral change in this PR.

crates/bevy_ecs/src/archetype.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/src/archetype.rs Show resolved Hide resolved
@stepancheg stepancheg force-pushed the archetype-component-id branch from 6bd73cf to 9f4ff00 Compare December 6, 2023 21:39
@stepancheg
Copy link
Contributor Author

  • kept integer overflow
  • added panic doc
  • replaced unwrap with expect

@stepancheg stepancheg requested a review from james7132 December 19, 2023 22:26
@james7132 james7132 added this pull request to the merge queue Feb 3, 2024
Merged via the queue into bevyengine:main with commit c55a5ba Feb 3, 2024
22 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@stepancheg @tjamaan
Make Archetypes.archetype_component_count private (bevyengine#10774)
ae16d3f 
Make more clear where it is used and how.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @james7132 @alice-i-cecile @ItsDoot