Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_resource_changed_by_id + is_resource_added_by_id #11012

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Add is_resource_changed_by_id + is_resource_added_by_id #11012

merged 2 commits into from
Dec 18, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Dec 17, 2023

Objective

  • Allow checking if a resource has changed by its ComponentId

Changelog

  • Added World::is_resource_changed_by_id() and World::is_resource_added_by_id().

@JMS55 JMS55 added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events labels Dec 17, 2023
matiqo15
matiqo15 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@matiqo15 matiqo15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks - technically, these comments are based on a previous comment, so this would require to change that one too, but that's for another PR.

crates/bevy_ecs/src/world/mod.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/src/world/mod.rs
Comment on lines +1207 to +1208
/// - When called from an exclusive system, this will check for additions since the system last ran.
/// - When called elsewhere, this will check for additions since the last time that [`World::clear_trackers`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change "this" to "it", feels easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about that, what do other people think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really is a nitpick and nothing relevant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, totally just a nitpick! I just felt like it would be easier to read, but it might just be me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this :p

crates/bevy_ecs/src/world/mod.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/src/world/mod.rs Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 18, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 18, 2023
Merged via the queue into bevyengine:main with commit 9a89fc4 Dec 18, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiqo15 matiqo15 matiqo15 approved these changes

@VVishion VVishion VVishion left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet Awaiting requested review from JoJoJet

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JMS55 @alice-i-cecile @VVishion @matiqo15