Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanup #11134

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Misc cleanup #11134

merged 2 commits into from
Dec 30, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Dec 29, 2023 •
edited
Loading

Re-exports a few types/functions I need that have no reason to be private, and some minor code quality changes.

@JMS55 JMS55 added the C-Code-Quality A section of code that is hard to understand or change label Dec 29, 2023
@JMS55 JMS55 requested a review from alice-i-cecile December 29, 2023 22:59
@ghost
Copy link

ghost commented Dec 29, 2023

Looks good to me, this is a pretty mechanical change, the variable renames are helpful.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 29, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 30, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 30, 2023
Merged via the queue into bevyengine:main with commit 3d3a065 Dec 30, 2023
22 checks passed
brianreavis added a commit to brianreavis/bevy that referenced this pull request Jan 1, 2024
@brianreavis
Export tonemapping_pipeline_key, alpha_mode_pipeline_key
34021f7 
This expands upon bevyengine#11134
@brianreavis brianreavis mentioned this pull request Jan 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2024
@brianreavis
Export tonemapping_pipeline_key (2d), alpha_mode_pipeline_key (#11166)
846a871 
This expands upon #11134.

I found myself needing `tonemapping_pipeline_key` for some custom 2d
draw functions. #11134 exported the 3d version of
`tonemapping_pipeline_key` and this PR exports the 2d version. I also
made `alpha_mode_pipeline_key` public for good measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torsteingrindvik torsteingrindvik torsteingrindvik approved these changes

@atlv24 atlv24 atlv24 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JMS55 @alice-i-cecile @atlv24 @torsteingrindvik