Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SceneSpawner::spawn_dynamic_sync to return InstanceID #11239

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Change SceneSpawner::spawn_dynamic_sync to return InstanceID #11239

merged 2 commits into from
Jan 6, 2024

Conversation

thebluefish
Copy link
Contributor

Objective

SceneSpawner::spawn_dynamic_sync currently returns () on success, which is inconsistent with the other SceneSpawner::spawn_ methods that all return an InstanceId. We need this ID to do useful work with the newly-created data.

Solution

Updated SceneSpawner::spawn_dynamic_sync to return Result<InstanceId, SceneSpawnError> instead of Result<(), SceneSpawnError>

Umatriz
Umatriz reviewed Jan 6, 2024
View reviewed changes
Copy link

@Umatriz Umatriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Umatriz
Umatriz approved these changes Jan 6, 2024 •
edited
Loading
View reviewed changes
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Scenes Serialized ECS data stored on the disk labels Jan 6, 2024
@alice-i-cecile
Copy link
Member

@thebluefish once this is formatted and passing CI I'll merge it in :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 6, 2024
Merged via the queue into bevyengine:main with commit cfcb688 Jan 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Umatriz Umatriz Umatriz approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebluefish @alice-i-cecile @Umatriz