Make DynamicUniformBuffer::push
accept an &T
instead of T
#11373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
DynamicUniformBuffer::push
takes an ownedT
but only uses a shared reference to itDynamicUniformBuffer::push
to potentially unecessarily clone dataSolution
DynamicUniformBuffer::push
take a shared reference toT
Changelog
DynamicUniformBuffer::push
now takes a&T
instead ofT
Migration Guide
DynamicUniformBuffer::push
now need to pass references toDynamicUniformBuffer::push
(e.g. existinguniforms.push(value)
will now becomeuniforms.push(&value)
)