Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accesskit_winit requirement from 0.17 to 0.18 #11466

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2024

Updates the requirements on accesskit_winit to permit the latest version.

Release notes

Sourced from accesskit_winit's releases.

accesskit_winit: v0.18.1

0.18.1 (2024-01-11)

Bug Fixes

  • Run our own async executor on Unix (#337) (8f937ba)
  • Show an error at compile-time if no raw-window-handle feature is enabled for the winit adapter (#339) (a24f5fd)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • accesskit_unix bumped from 0.7.0 to 0.7.1
Commits
  • 03bc0f9 chore: release main (#338)
  • a24f5fd fix: Show an error at compile-time if no raw-window-handle feature is enabled...
  • 8f937ba fix: Run our own async executor on Unix (#337)
  • c034802 fix: Make full use of tokio ecosystem if the tokio feature is enabled on Unix...
  • 432dd7a chore: release main (#335)
  • 3725373 fix: Decrease minimum Python version to 3.8 for Python bindings (#334)
  • dcf824e ci: Simplify C bindings asset generation (#333)
  • 3be91ea chore: release main (#326)
  • 23b3f2f fix: Bump objc2 to 0.5.0; bring icrate 0.1.0 (#323)
  • 52560da feat: Add Python bindings (#269)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Jan 22, 2024
@alice-i-cecile alice-i-cecile added the A-Accessibility A problem that prevents users with disabilities from using Bevy label Jan 22, 2024
@james7132
Copy link
Member

The fact that accesskit now uses it's own async executor (AccessKit/accesskit#337) means that a tokio or async-std runtime is now necessary to be bundled on Unix platforms. This also imposes restrictions on our initialization by requiring the appropriate main macro for the target async executor for this to work.

Updates the requirements on [accesskit_winit](https://github.com/AccessKit/accesskit) to permit the latest version.
- [Release notes](https://github.com/AccessKit/accesskit/releases)
- [Changelog](https://github.com/AccessKit/accesskit/blob/main/release-please-config.json)
- [Commits](AccessKit/accesskit@accesskit_winit-v0.17.0...accesskit_winit-v0.18.1)

---
updated-dependencies:
- dependency-name: accesskit_winit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/accesskit_winit-0.18 branch from 809284d to 8ceff09 Compare January 26, 2024 18:32
@alice-i-cecile alice-i-cecile added the S-Blocked This cannot move forward until something else changes label Jan 26, 2024
@mwcampbell
Copy link

There is no such requirement on initialization. That's the whole reason we run an async executor on its own thread. As you can see in accesskit_winit's example, and in the accesskit_winit Unix backend itself, the async stuff is entirely internal to accesskit_unix.

@BD103 BD103 closed this Apr 22, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 22, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/accesskit_winit-0.18 branch April 22, 2024 17:09
@BD103
Copy link
Member

BD103 commented Apr 22, 2024

Closing this because #12973 has been created for accesskit_winit 0.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants