mipmap levels can be 0 and they should be interpreted as 1

[anarelion]

Objective

Loading some textures from the days of yonder give me errors cause the mipmap level is 0

Solution

Set a minimum of 1

Changelog

Make mipmap level at least 1

[doonv]

I feel like we should give a warning when the mipmap level is invalid instead of just silently fixing the problem.

[alice-i-cecile]

I agree that a warning would be nice. Unsure if we can get away with a warn_once! in here without costing performance.

[doonv]

Unsure if we can get away with a warn_once! in here without costing performance.

We could make it only happen when cfg(debug_assertions) is enabled.

[anarelion]

Now it should be properly done, sorry for the spam, I thought everything was ok, but 2 minute later rust analyzer came back with more problems

[alice-i-cecile]

Looks like CI is still missing an import of warn_once! :)

[anarelion]

Looks like CI is still missing an import of warn_once! :)

Thanks, didn't check all features. Still learning how to work with git/github and this project. I am a mercurial person

[anarelion]

I don't know how to get around the duplicated versions problem, I guess there is not much I can do. Seems to be

     ┌─ /home/runner/work/bevy/bevy/Cargo.lock:342:1
    │  
342 │ ╭ raw-window-handle 0.5.2 registry+https://github.com/rust-lang/crates.io-index
343 │ │ raw-window-handle 0.6.0 registry+https://github.com/rust-lang/crates.io-index
    │ ╰─────────────────────────────────────────────────────────────────────────────^ lock entries

[alice-i-cecile]

Yeah, the duplicated dependencies is not your problem: it's the result of us updating versions. Won't block the merge though.

[anarelion]

Is there anything else I can do to get this merged?

[SludgePhD]

This is a public API, so this will break bevy plugins using it if the "wrong" build configuration is enabled by the user.

tracing allows attaching this information to a Span instead, which is a better way to do this (the warn_once! will include the span's fields).