Cache the QueryState used to drop swapchain TextureViews #11781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Rendering
alice-i-cecile
approved these changes
Feb 8, 2024
JMS55
approved these changes
Feb 8, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While profiling around to validate the results of #9172, I noticed that
present_framescan take a significant amount of time. Digging into the cause, it seems like we're creating a newQueryStatefrom scratch every frame. This involves scanning the entire World's metadata instead of just updating its view of the world.Solution
Use a
SystemStateargument to cache theQueryStateto avoid this construction cost.Performance
Against
many_foxes, this seems to cut the time spent inpresent_framesby nearly almost 2x. Yellow is this PR, red is main.